RFR: jsr166 jdk9 integration wave 4

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: jsr166 jdk9 integration wave 4

Martin Buchholz-3
After much debate on what to do when CompleteableFuture.whenComplete
encounters an exception in both the source and the action, we chose
what was acceptable to the most people - add the action's exception to
the source exception as a suppressed exception.  And added usage
guidelines.  And gave handle "top billing" over whenComplete.

http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/

and the usual miscellaneous improvements.
_______________________________________________
Concurrency-interest mailing list
[hidden email]
http://cs.oswego.edu/mailman/listinfo/concurrency-interest
Reply | Threaded
Open this post in threaded view
|

Re: RFR: jsr166 jdk9 integration wave 4

Chris Hegarty

On 1 Feb 2016, at 18:45, Martin Buchholz <[hidden email]> wrote:

> After much debate on what to do when CompleteableFuture.whenComplete
> encounters an exception in both the source and the action, we chose
> what was acceptable to the most people - add the action's exception to
> the source exception as a suppressed exception.  And added usage
> guidelines.  And gave handle "top billing" over whenComplete.
>
> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/

This all looks fine to me.

So I assume you only need a small CCC request for CompletionStage, right?
Everything else is implementation.

-Chris.
_______________________________________________
Concurrency-interest mailing list
[hidden email]
http://cs.oswego.edu/mailman/listinfo/concurrency-interest
Reply | Threaded
Open this post in threaded view
|

Re: RFR: jsr166 jdk9 integration wave 4

Martin Buchholz-3
On Tue, Feb 2, 2016 at 6:37 AM, Chris Hegarty <[hidden email]> wrote:

>
> On 1 Feb 2016, at 18:45, Martin Buchholz <[hidden email]> wrote:
>
>> After much debate on what to do when CompleteableFuture.whenComplete
>> encounters an exception in both the source and the action, we chose
>> what was acceptable to the most people - add the action's exception to
>> the source exception as a suppressed exception.  And added usage
>> guidelines.  And gave handle "top billing" over whenComplete.
>>
>> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/
>
> This all looks fine to me.
>
> So I assume you only need a small CCC request for CompletionStage, right?
> Everything else is implementation.

If you squint you might argue that CompletionStage's contract hasn't
actually changed,
but yeah, go ahead and do a CCC for CompletionStage.  Publishing a
specdiff would be nice - method reordering (for "top billing") has
made the diffs harder to review.  Thanks.
_______________________________________________
Concurrency-interest mailing list
[hidden email]
http://cs.oswego.edu/mailman/listinfo/concurrency-interest
Reply | Threaded
Open this post in threaded view
|

Re: RFR: jsr166 jdk9 integration wave 4

Paul Sandoz
In reply to this post by Martin Buchholz-3

> On 1 Feb 2016, at 19:45, Martin Buchholz <[hidden email]> wrote:
>
> After much debate on what to do when CompleteableFuture.whenComplete
> encounters an exception in both the source and the action, we chose
> what was acceptable to the most people - add the action's exception to
> the source exception as a suppressed exception.  And added usage
> guidelines.  And gave handle "top billing" over whenComplete.
>
> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/
>
> and the usual miscellaneous improvements.

+1

Looks like the diffs got swapped for EmptyNavigableSet.java in the misc patch:

http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/patches/jsr166-jdk9-integration-miscellaneous

diff --git a/test/java/util/Collections/EmptyNavigableSet.java b/test/java/util/Collections/EmptyNavigableSet.java
--- a/test/java/util/Collections/EmptyNavigableSet.java
+++ b/test/java/util/Collections/EmptyNavigableSet.java
@@ -284,7 +284,7 @@
                     navigableSet.subSet(last, true, first, false);
                 },
                 IllegalArgumentException.class, description
-                + ": Must throw IllegalArgumentException when fromElement is not less than toElement.");
+                + ": Must throw IllegalArgumentException when fromElement is not less then then toElement.”);

Paul.

_______________________________________________
Concurrency-interest mailing list
[hidden email]
http://cs.oswego.edu/mailman/listinfo/concurrency-interest

signature.asc (858 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: RFR: jsr166 jdk9 integration wave 4

Martin Buchholz-3
On Mon, Feb 8, 2016 at 2:09 AM, Paul Sandoz <[hidden email]> wrote:

>
>> On 1 Feb 2016, at 19:45, Martin Buchholz <[hidden email]> wrote:
>>
>> After much debate on what to do when CompleteableFuture.whenComplete
>> encounters an exception in both the source and the action, we chose
>> what was acceptable to the most people - add the action's exception to
>> the source exception as a suppressed exception.  And added usage
>> guidelines.  And gave handle "top billing" over whenComplete.
>>
>> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/
>>
>> and the usual miscellaneous improvements.
>
>
> +1
>
> Looks like the diffs got swapped for EmptyNavigableSet.java in the misc patch:

Thanks, fixed.

This is a result of having bidirectional changes flowing between
different source code control systems and no merge bridging tool.  (I
don't think I've regressed an upstream change yet, but I'm careful
before doing any hg push.  I've modified my upstreaming script to warn
me about such conflicts in the future)
_______________________________________________
Concurrency-interest mailing list
[hidden email]
http://cs.oswego.edu/mailman/listinfo/concurrency-interest